Add ZeroVec stack size tests #3427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
May 12, 2023
|
I'd also like to consider making ZeroMaps be VarULE such that they can be the same size as a VarZeroVec. The easy way to do this is to just put the indices and values into the same buffer, one after the other; the offsets can be deterministically computed in a way that I expect to be negligible. It would be nice to do this at the same time as the ZeroIndex work. |
|
Yes, I've wanted that for a while. |
Manishearth
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few more size tests in relation to #3413
ZeroVec is the same size as a Vec. I guess we can't easily make it any smaller.
VarZeroVec is 4 words. I think we lose a whole word because of the enum.
ZeroMap is the size of its two components.
ZeroMap2d is the size of three components plus the joiner array. This adds up very quickly!
FlexZeroVec is the same as ZeroVec.
Options of these types add a word for ZeroVec and FlexZeroVec but not for VarZeroVec, ZeroMap, or ZeroMap2d.