-
Notifications
You must be signed in to change notification settings - Fork 213
1.1.0 #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0 #3018
Conversation
@robertbastian @sffc can we land #2949 and bump Yoke first? it's technically a breaking change. I'd rather not block that on IsCovariant, a thing which is currently unused and I'd like to redesign again based on actual need. |
I haven't seen any activity on that PR, and it's not in the 1.1 Blocking milestone. What's the ETA on it? |
@robertbastian it should be mergeable once Shane responds it didn't occur to me that it should be blocking, but i think it should |
@robertbastian feel free to roll #3019 into your PR, but I can just merge and publish independently |
Also, changelog for Yoke
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't read up yet on cargo workspaces
but it looks like it might be quite helpful
@@ -24,18 +24,21 @@ include = [ | |||
"README.md" | |||
] | |||
|
|||
[package.metadata.workspaces] | |||
independent = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure what are the implications of this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo ws version
can be used to bump the versions. By default all crates are versioned together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove these [package.metadata.workspaces]
lines now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still suggest cargo ws version
to bump version, it's really convenient.
Hmm, won't |
Can we use Cargo's regular workspace-level versioning support? It's not available on our MSRV, but that doesn't actually matter since local tests won't hit it (I think?), and I'd like to stay as close to vanilla Cargo as possible. I'm worried about introducing a dependency on a new tool which is only invoked once in a blue moon (making it much harder to catch any bugs). We have problems with And plus; publishes aren't a retryable operation; if a publish succeeds but was run with the wrong options, you can't really undo that. I'm still unclear on how this tool works but it ... might be doing some Cargo.toml fixups before publishing, which seems super brittle. I'm fine with using this tool for bumping stuff, but highly suspicious about requiring it for publishing. |
I was expected I don't think we can use "workspace-level versioning support" because then our MSRV CI would fail (although I guess we could do something like |
I'm pretty sure The well-trodden path that has worked for us in previous releases is to just go ahead and update all the version numbers and then |
It doesn't in my experience. And part of this is just that a local path dependency points to a specific crate, whereas Cargo.toml deps are a range. Which means this is going to be a problem for us once we want to do patch releases and stuff, since we'll sometimes want a crate to bump its dep on, say, yoke, whereas in other cases the yoke change may be purely internal and not require a dep bump. So I'd say we should undo these changes.
Yeah, I was hoping Cargo would silently ignore |
I was hoping to improve on that because that's a lot of stupid work, but alas not. |
Also, if you discover any further issues while publishing (not unlikely), so long as they are only Cargo.toml changes, I've usually pushed them directly to the main branch and asked for a post-submit review |
I'm not sure I can push to main. |
icu_calendar
icu_casemapping
icu_collator
icu_collections
icu_codepointtrie_builder
icu_datetime
icu_decimal
icu_displaynames
icu_list
Writeable
s for regex evaluation #2991)icu_locid
write_to_string
(More borrowing in locid'swrite_to_string
#2693)icu_locid_transform
icu_normalizer
icu_plurals
icu_properties
icu_segmenter
#[no_std]
for LSTM segmenter (#[no_std]
for LSTM segmenter #2845)icu_timezone
icu_provider_adapters
icu_provider_blob
icu_provider
DataError
for.as_deserializing()
,.as_downcasting()
#2993)icu_datagen
icu_provider_fs
icu_testdata
bies
databake
fixed_decimal
icu_pattern
litemap
tinystr
std
feature and Error impl forTinyStrError
#3009)tzif
writeable
core
integer log when available #3015)usize
andisize
implementationyoke
prove_covariance_manually
guard forCoerceUnsized
(Add prove_covariance_manually guard for CoerceUnsized #2936)clippy::forget_copy
inderive(Yokeable)
impl (Allow clippy::forget_copy in derive(Yokeable) impl #2775)Yoke::attach_to_cart()
around implied bounds Fix soundness issue in Yoke::attach_to_cart() around implied bounds #2949zerovec