-
Notifications
You must be signed in to change notification settings - Fork 214
First part of glue code for HarfBuzz #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this with @echeran. Looks quite good; thanks for figuring out how to do these bindings!
So at a high level this looks really great! One thing I'm wondering about is whether this should go into the metacrate. I kind of feel that this isn't an ICU4X component as much as it is an ICU4X integration (or "port"). A lot of the stuff under I also don't want a native dependency in our default deptree 😄 We can play around with that, of course. |
Agree that it would be nice to avoid native deps in the icu metacrate. I think this should just be a standlone crate. |
Concretely, how should I place this crate in the repo's directory structure? |
Discussed in today's call. It should be |
@hsivonen What's the status of this PR? Are you waiting on reviewers or is there more you plan to do first? |
Discussion: put this in the workspace but not the metacrate. |
I have both 1) removed |
Apparently tests need Harfbuzz itself to be built. |
Towards #2514.
I have reserved the crate name: https://crates.io/crates/icu_harfbuzz