Big icu_provider renaming
#2207
Conversation
robertbastian
requested review from
a team,
Manishearth,
sffc,
filmil,
aethanyc,
makotokato,
zbraniecki,
hsivonen,
echeran,
dminor,
gregtatum and
nordzilla
as code owners
robertbastian
removed request for
a team,
aethanyc,
filmil,
dminor,
zbraniecki,
hsivonen,
echeran,
makotokato,
gregtatum and
nordzilla
| @@ -75,7 +75,7 @@ | |||
|
|
|||
| - General data model | |||
| - `DataPayload` no longer needs a lifetime (#1297, #1279) | |||
| - Re-write ResourceKey (#1511) | |||
| - Re-write DataKey (#1511) | |||
There was a problem hiding this comment.
Nit: Don't backport name changes to docs and changelog that are temporal
There was a problem hiding this comment.
We have actually done this in other renamings as well (Format -> Formatter). I think it makes sense, these are clean renames and the change log will be harder to interpret if the names in it don't exist anymore.
| @@ -126,12 +126,12 @@ impl Collator { | |||
| } | |||
| filtered_locale | |||
| }; | |||
| let resource_options: ResourceOptions = locale.into(); | |||
| let data_options: DataOptions = locale.into(); | |||
There was a problem hiding this comment.
Nit (optional): Since you're in this code anyway would you consider changing it to DataLocale now? If not or you still want to talk about that, it can be done later
There was a problem hiding this comment.
These are the names we've agreed on for now, let's do this separately. DataLocale also requires renaming lots of variables from options to locale, so it's actually more than just renaming the type.
Part of #1576