Cleaning up resource_keys! and improving doc #1540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
aethanyc,
dminor,
gregtatum,
makotokato,
Manishearth,
nordzilla,
sffc,
zbraniecki and
a team
as code owners
robertbastian
removed request for
a team,
aethanyc,
dminor,
zbraniecki,
makotokato,
gregtatum and
nordzilla
sffc
previously approved these changes
Jan 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
- Coverage 77.03% 77.01% -0.03%
==========================================
Files 310 310
Lines 19061 19042 -19
==========================================
- Hits 14684 14665 -19
Misses 4377 4377
Continue to review full report at Codecov.
|
Manishearth
previously approved these changes
Jan 26, 2022
sffc
previously approved these changes
Jan 27, 2022
Manishearth
approved these changes
Jan 27, 2022
| @@ -114,9 +114,10 @@ impl ResourceKey { | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
| pub const fn try_new(path: &'static str) -> Option<Self> { | |||
| // Error is a str of the expected character class and the index where it wasn't encountered | |||
| pub const fn construct_internal(path: &'static str) -> Result<Self, (&'static str, usize)> { | |||
There was a problem hiding this comment.
thought: we probably should use an enum for the error types? I guess a string is fine
There was a problem hiding this comment.
Well this is not really public, so I don't want to add another hidden API. This should get DCE'd so we don't have the strings in the binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #570