Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22837 Update config.guess config.sub for WASI support #3066

Conversation

kateinoigakukun
Copy link
Contributor

@kateinoigakukun kateinoigakukun commented Jul 25, 2024

WASI targets (e.g. wasm32-unknown-wasi) are not detected with the current config.guess/config.sub, which date back to 2017.

The latest config.guess and config.sub in https://git.savannah.gnu.org/cgit/config.git have WASI target support, so we need to update them to prepare for the upcoming WASI support patch set.

These files are copied from:

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22837
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu changed the title ICU-22837 Update config.guess configu.sub for WASI support ICU-22837 Update config.guess config.sub for WASI support Aug 15, 2024
@markusicu
Copy link
Member

@srl295 please compare with upstream; will configure need to be regenerated?

@markusicu
Copy link
Member

@srl295 please compare with upstream; will configure need to be regenerated?

In the meantime, @roubert has updated the autoconf scripts, including regenerating the configure script. (#3169)
This is also why there are merge conflicts here now.

Closing this PR, assuming that there is nothing here except updating a subset of the same files.

@markusicu markusicu closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants