Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard fix 1 #4537

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Dashboard fix 1 #4537

wants to merge 9 commits into from

Conversation

srugano
Copy link
Contributor

@srugano srugano commented Dec 24, 2024

No description provided.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (6bc3969) to head (30bc8dc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4537   +/-   ##
========================================
  Coverage    84.98%   84.98%           
========================================
  Files          514      514           
  Lines        36282    36284    +2     
========================================
+ Hits         30833    30837    +4     
+ Misses        5449     5447    -2     
Flag Coverage Δ
e2e 62.46% <75.00%> (+<0.01%) ⬆️
unittests 83.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srugano
Copy link
Contributor Author

srugano commented Jan 7, 2025

@pkujawa this test_create_pending_objects_from_objects keeps failing.

@pkujawa
Copy link
Contributor

pkujawa commented Jan 9, 2025

@srugano I fixed the flaky test (https://github.com/unicef/hope/pull/4546)
It was failing because our HouseholdFactory has
first_registration_date = factory.Faker("date_time_this_year", before_now=True, after_now=False, tzinfo=utc)
and with the beginning of the new year, it had a high chance of having the same date as "today"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants