Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#226656 Error Cannot read properties of undefined Grievance ticket #4525

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Dec 12, 2024

This pull request includes several changes to improve the robustness of the LookUpReassignRole and ReassignMultipleRoleBox components by adding optional chaining to handle potential undefined values. The most important changes are:

Enhancements to handle potential undefined values:

Code cleanup:

@johniak johniak enabled auto-merge December 12, 2024 15:04
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (f466892) to head (5fb9b23).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4525      +/-   ##
==========================================
- Coverage   84.67%   84.65%   -0.02%     
==========================================
  Files         508      508              
  Lines       36224    36224              
==========================================
- Hits        30671    30665       -6     
- Misses       5553     5559       +6     
Flag Coverage Δ
e2e 62.61% <ø> (+0.01%) ⬆️
unittests 82.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johniak johniak merged commit 62c8f66 into master Dec 13, 2024
13 checks passed
@johniak johniak deleted the hotfix/AB#226656-Error-Cannot-read-properties-of-undefined-Grievance-ticket branch December 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants