Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[225556] generateroles in upgrade but skip updating existing roles #4515

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

pkujawa
Copy link
Contributor

@pkujawa pkujawa commented Dec 10, 2024

@pkujawa pkujawa self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (5b15e07) to head (3228cd2).
Report is 3 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #4515      +/-   ##
===========================================
+ Coverage    84.66%   84.67%   +0.01%     
===========================================
  Files          508      508              
  Lines        36224    36224              
===========================================
+ Hits         30668    30672       +4     
+ Misses        5556     5552       -4     
Flag Coverage Δ
e2e 62.61% <ø> (+0.01%) ⬆️
unittests 82.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkujawa pkujawa merged commit 6c66922 into staging Dec 11, 2024
13 checks passed
@pkujawa pkujawa deleted the generateroles_handle_2 branch December 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants