Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Permissions new rework #4409

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

pkujawa
Copy link
Contributor

@pkujawa pkujawa commented Nov 5, 2024

No description provided.

Rename UserRole -> RoleAssignment
Test model constraints
@pkujawa pkujawa added the backend Changes in BE code label Nov 5, 2024
@pkujawa pkujawa self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 27.48344% with 219 lines in your changes missing coverage. Please review.

Project coverage is 23.43%. Comparing base (60bf4d0) to head (a1abe92).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/core/backends.py 0.00% 70 Missing ⚠️
src/hct_mis_api/apps/account/models.py 31.42% 48 Missing ⚠️
src/hct_mis_api/apps/account/signals.py 57.40% 23 Missing ⚠️
src/hct_mis_api/apps/account/celery_tasks.py 0.00% 20 Missing ⚠️
src/hct_mis_api/apps/account/schema.py 0.00% 12 Missing ⚠️
src/hct_mis_api/apps/core/utils.py 16.66% 10 Missing ⚠️
src/hct_mis_api/apps/account/admin/user.py 25.00% 6 Missing ⚠️
src/hct_mis_api/apps/account/filters.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/account/permissions.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/grievance/schema.py 0.00% 4 Missing ⚠️
... and 11 more

❗ There is a different number of reports uploaded between BASE (60bf4d0) and HEAD (a1abe92). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (60bf4d0) HEAD (a1abe92)
unittests 2 0
e2e 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4409       +/-   ##
============================================
- Coverage    84.64%   23.43%   -61.22%     
============================================
  Files          504      509        +5     
  Lines        36199    36088      -111     
============================================
- Hits         30642     8457    -22185     
- Misses        5557    27631    +22074     
Flag Coverage Δ
e2e 23.43% <27.48%> (-39.14%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant