Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[217496] Beneficiary Groups #4366

Merged
merged 113 commits into from
Dec 10, 2024
Merged

[217496] Beneficiary Groups #4366

merged 113 commits into from
Dec 10, 2024

Conversation

pkujawa
Copy link
Contributor

@pkujawa pkujawa commented Oct 23, 2024 •
edited by azure-boards bot
Loading

pkujawa and others added 4 commits October 22, 2024 22:59
@pkujawa
Add Beneficiary Group model.
1b6712d 
Add admin page and filtering in program list
Apply Beneficiary Group logic in update/create program, in admin enroll actions.
Add beneficiary group match filter for All Programs
Add API Rest endpoint for Beneficiary Group with caching.
Add validation for import program population.
@pkujawa
Add tests
9f50779
@pkujawa
Merge branch 'develop' into 218655-beneficiary-group
f69fe91
@pkujawa
Add tests
80f844a
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.15254% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (a82aa7b) to head (f069438).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/program/models.py 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4366      +/-   ##
===========================================
+ Coverage    84.66%   84.74%   +0.08%     
===========================================
  Files          508      510       +2     
  Lines        36247    36353     +106     
===========================================
+ Hits         30688    30807     +119     
+ Misses        5559     5546      -13
Flag Coverage Δ
e2e 62.41% <86.44%> (-0.18%) ⬇️
unittests 82.95% <99.15%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkujawa and others added 4 commits October 23, 2024 20:02
@pkujawa
Add more tests
3b569ea
@pkujawa
Merge branch 'develop' into 218655-beneficiary-group
5a18887
@pkujawa
Add default beneficiary group
5d099b6
@pkujawa
More tests
88ce06b 
Fixes to program mutations
Add BeneficiaryGroup to ProgramNode
Fix build for HouseholdFactory
@pkujawa pkujawa self-assigned this Oct 24, 2024
@pkujawa pkujawa added the backend Changes in BE code label Oct 24, 2024
@pkujawa pkujawa changed the title 218655 beneficiary group [217496] Beneficiary Groups Oct 24, 2024
@mmaciekk mmaciekk self-assigned this Nov 21, 2024
@mmaciekk mmaciekk added the frontend Changes in FE code label Nov 21, 2024
@pavlo-mk
Copy link
Contributor

I can take a look on unit tests 👀

@mmaciekk mmaciekk marked this pull request as ready for review December 10, 2024 15:40
@pavlo-mk pavlo-mk merged commit 2a9e429 into develop Dec 10, 2024
13 checks passed
@pavlo-mk pavlo-mk deleted the 218655-beneficiary-group branch December 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekBiczysko MarekBiczysko MarekBiczysko approved these changes

@mmaciekk mmaciekk mmaciekk approved these changes

Assignees

@pavlo-mk pavlo-mk

@mmaciekk mmaciekk

@pkujawa pkujawa

@szymon-kellton szymon-kellton

Labels
backend Changes in BE code frontend Changes in FE code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pkujawa @pavlo-mk @mmaciekk @MarekBiczysko @szymon-kellton