Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202443_Payment_Module_Configure_Mobile_money_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway #4020

Conversation

MarekBiczysko
Copy link
Contributor

@MarekBiczysko MarekBiczysko commented Jul 8, 2024

…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (7930371) to head (3985393).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4020      +/-   ##
===========================================
+ Coverage    81.02%   81.06%   +0.04%     
===========================================
  Files          399      399              
  Lines        32564    32575      +11     
  Branches      5350     5351       +1     
===========================================
+ Hits         26384    26407      +23     
+ Misses        5254     5242      -12     
  Partials       926      926              
Flag Coverage Δ
e2e 53.11% <0.00%> (-0.02%) ⬇️
unittests 79.14% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domdinicola
Copy link
Collaborator

@MarekBiczysko together with this we need to add a flex field at database level, correct?

@MarekBiczysko
Copy link
Contributor Author

MarekBiczysko commented Jul 8, 2024

@MarekBiczysko together with this we need to add a flex field at database level, correct?
@domdinicola
I believe this should be done by an end user via django admin?

@@ -115,20 +115,14 @@ def get_extra_data(self, obj: Payment) -> Dict:
return {}

def get_payload(self, obj: Payment) -> Dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use TypedDict here to create some kind of contract

marekbiczysko and others added 7 commits July 10, 2024 12:04
…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
…echanisms_to_send_payment_records_to_WU_through_Payment_Gateway' of github.com:unicef/hct-mis into 202443_Payment_Module_Configure_Mobile_money_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
…ney_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway
@MarekBiczysko MarekBiczysko merged commit 54f2142 into develop Jul 11, 2024
13 checks passed
@MarekBiczysko MarekBiczysko deleted the 202443_Payment_Module_Configure_Mobile_money_delivery_mechanisms_to_send_payment_records_to_WU_through_Payment_Gateway branch July 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants