Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[196847] No validate end date for existing programmes #3847

Merged
merged 1 commit into from
May 13, 2024

Conversation

patryk-dabrowski
Copy link
Contributor

@patryk-dabrowski patryk-dabrowski commented May 9, 2024

@patryk-dabrowski patryk-dabrowski added the frontend Changes in FE code label May 9, 2024
@patryk-dabrowski patryk-dabrowski self-assigned this May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (b117b87) to head (6843080).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3847      +/-   ##
===========================================
+ Coverage    74.91%   74.96%   +0.04%     
===========================================
  Files          398      398              
  Lines        31969    31969              
  Branches      5204     5204              
===========================================
+ Hits         23950    23964      +14     
+ Misses        7101     7088      -13     
+ Partials       918      917       -1     
Flag Coverage Δ
e2e 20.60% <ø> (?)
unittests 74.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pkujawa pkujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the requirements (specified more in the comments) - the validation should be omitted only if editing FINISHED program

@patryk-dabrowski
Copy link
Contributor Author

According to the requirements (specified more in the comments) - the validation should be omitted only if editing FINISHED program

@pkujawa What do you mean by FINISHED program? we cannot edit programs with FINISHED status at all

@pkujawa
Copy link
Contributor

pkujawa commented May 10, 2024

According to the requirements (specified more in the comments) - the validation should be omitted only if editing FINISHED program

@pkujawa What do you mean by FINISHED program? we cannot edit programs with FINISHED status at all

Oh you are right. I misunderstood the comment then, apologies :D Just seemed weird to omit the validation for general program update since this validation will not bring any value now. But you are right, this is according to the requirement

@patryk-dabrowski patryk-dabrowski merged commit 67d8ccc into develop May 13, 2024
13 checks passed
@patryk-dabrowski patryk-dabrowski deleted the fix/196847 branch May 13, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Changes in FE code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants