Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOPE Add PDM #3751

Merged
merged 46 commits into from
May 14, 2024
Merged

HOPE Add PDM #3751

merged 46 commits into from
May 14, 2024

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Apr 2, 2024

AB#182432: move HOPE to PDM

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Apr 2, 2024
@pavlo-mk pavlo-mk self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (011ed0d) to head (7d7c845).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3751      +/-   ##
===========================================
+ Coverage    76.08%   76.14%   +0.05%     
===========================================
  Files          398      398              
  Lines        32054    32054              
  Branches      5222     5222              
===========================================
+ Hits         24388    24406      +18     
+ Misses        6750     6732      -18     
  Partials       916      916              
Flag Coverage Δ
e2e 44.23% <0.00%> (ø)
unittests 75.28% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk marked this pull request as ready for review April 9, 2024 11:15
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Apr 9, 2024
@pavlo-mk pavlo-mk changed the title WIP // Add PDM HOPE Add PDM Apr 9, 2024
backend/.pdm-python Outdated Show resolved Hide resolved
Copy link
Contributor

@patryk-dabrowski patryk-dabrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you also update this script https://github.com/unicef/hct-mis/blob/develop/deployment/bump_version.sh ?

@pavlo-mk pavlo-mk marked this pull request as ready for review May 10, 2024 15:06
backend/pyproject.toml Outdated Show resolved Hide resolved
@pavlo-mk pavlo-mk merged commit 8a1fd49 into develop May 14, 2024
13 checks passed
@pavlo-mk pavlo-mk deleted the 182432_add_pdm branch May 14, 2024 10:50
@domdinicola
Copy link
Collaborator

@pavlo-mk well done!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants