Update DCT limit_to filters #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlo-mk
requested review from
pkujawa,
KonradMarzec1991,
johniak and
MarekBiczysko
pkujawa
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Actually, with the naming it should stay the same: limit_to.
Since you are changing that if limit_to is empty -> it should be applied to all BAs (because we are not limiting).
The issue was that with the previous logic, it should be named available for - because if that was empty, we would treat it as if DCT was not available for any BA.
|
@saxix |
johniak
approved these changes
Mar 6, 2024
pkujawa
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#190204: Data Collecting Type not available