add ! name and description to DeduplicationSet #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #81 +/- ##
===========================================
+ Coverage 94.41% 94.59% +0.17%
===========================================
Files 67 71 +4
Lines 1414 1461 +47
Branches 161 165 +4
===========================================
+ Hits 1335 1382 +47
Misses 58 58
Partials 21 21 ☔ View full report in Codecov by Sentry. |
domdinicola
reviewed
Sep 20, 2024
| def short_name(self, obj): | ||
| if obj.name: | ||
| return ( | ||
| (obj.name[:MAX_STR_DISPLAY_LENGTH] + "...") |
There was a problem hiding this comment.
let's remove this truncates
| def shorten(text: str, trim: int = MAX_STR_DISPLAY_LENGTH) -> str: | ||
| return ( | ||
| (text[:trim] + "...") | ||
| if text and len(text) > trim |
There was a problem hiding this comment.
let's remove the trim
| else text or EMPTY_PLACEHOLDER | ||
| ) | ||
|
|
||
| if not self.name and not self.description: |
There was a problem hiding this comment.
let's ignore description
del ! error from DeduplicationSet chg ! admin panel
vitali-yanushchyk-valor
force-pushed
the
feature/#76_add_fields
branch
from
d01a0a6
to
cb5afeb
Compare
domdinicola
reviewed
Sep 20, 2024
| from uuid import uuid4 | ||
|
|
||
| from django.conf import settings | ||
| from django.db import models | ||
|
|
||
| from hope_dedup_engine.apps.security.models import ExternalSystem | ||
|
|
||
| REFERENCE_PK_LENGTH = 100 | ||
| REFERENCE_PK_LENGTH: Final[int] = 100 |
There was a problem hiding this comment.
is this still used? @vitali-yanushchyk-valor
There was a problem hiding this comment.
is this still used? @vitali-yanushchyk-valor
Yes - it's other part of code. @domdinicola
domdinicola
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
del ! error from DeduplicationSet
chg ! admin panel