Replace 3rd party django hstore #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 3rd party library
django-hstorewith native Django functionality. (hstorehas been native since django 1.8)Removing
django-hstoreremoves an impediment to upgrading to Django 1.10.django-hstoreisn't compatible with Django 1.10. The author is aware of this but has no more time to maintain the module and is looking for a new maintainer.djangonauts/django-hstore#154
djangonauts/django-hstore#161
Also make
partners/models.pyflake8 clean (in the 2nd commit).This PR against
pmp-redesignreplaces PR #753 which did the same thing againstdevelop.This PR is a bit of pain to test because it affects a
0001_initial.pymigration. To test it properly (AFAICT) one has to delete one's database and start fresh to get the altered migration applied.