Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch29038] remove user profile model #1733

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ch29038] remove user profile model #1733

wants to merge 1 commit into from

Conversation

domdinicola
Copy link
Contributor

[ch29038]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #29038: Remove user profile model in PRP.

@domdinicola domdinicola force-pushed the 29038-remove-user-profile branch 3 times, most recently from 950588c to 1717520 Compare April 12, 2022 18:08
@domdinicola domdinicola requested a review from emaciupe April 12, 2022 18:22
emaciupe
emaciupe reviewed Apr 15, 2022
View reviewed changes
Copy link
Contributor

@emaciupe emaciupe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good!
One question: I see in the dev env that the /user-profile/ is being called.
Will that be removed in the FE as well?

@domdinicola domdinicola force-pushed the 29038-remove-user-profile branch from 1717520 to 46cf827 Compare May 6, 2022 14:03
@domdinicola
Copy link
Contributor Author

@emaciupe that's using only user model

@domdinicola domdinicola force-pushed the 29038-remove-user-profile branch from 46cf827 to 4f20581 Compare May 6, 2022 15:36
@domdinicola domdinicola force-pushed the 29038-remove-user-profile branch from 4f20581 to 714f689 Compare May 6, 2022 16:07
@robertavram robertavram added On hold and removed Ready labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaciupe emaciupe emaciupe left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
On hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domdinicola @emaciupe @robertavram