forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-38888][BUILD][CORE][YARN][DOCS] Add
RocksDB support for shuf…
…fle service state store ### What changes were proposed in this pull request? This is a extended work of SPARK-38909, in this pr, the `RocksDB` implementation is added for shuffle local state store. This PR adds the following code: - `shuffledb.RocksDB` and `shuffledb.RocksDBIterator`: implementation of RocksDB corresponding to `shuffledb.DB` and `shuffledb.DBIterator` - Add `ROCKSDB` to shuffle.DBBackend and the corresponding file suffix is `.rdb` and the description of `SHUFFLE_SERVICE_DB_BACKEND` in also changed - Add `RocksDBProvider` to build `RocksDB` instance and extend `DBProvider` to produce corresponding instances - Add dependency of `rocksdbjni` to `network-common` module ### Why are the changes needed? Support shuffle local state store to use RocksDB ### Does this PR introduce _any_ user-facing change? When user configures `spark.shuffle.service.db.enabled` as true, the user can use rocksdb as the shuffle lcoal state store by specifying `SHUFFLE_SERVICE_DB_BACKEND(spark.shuffle.service.db.backend)` as `RocksDB` in `spark-default.conf` or `spark-shuffle-site.xml(for yarn)`. The original data store in `LevelDB/RocksDB` will not be automatically convert to another kind of storage now. ### How was this patch tested? Add new test. Closes apache#37610 from LuciferYang/SPARK-38888. Authored-by: yangjie01 <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
- Loading branch information
1 parent
6577c43
commit e83aedd
Showing
14 changed files
with
424 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
common/network-common/src/main/java/org/apache/spark/network/shuffledb/RocksDB.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.network.shuffledb; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import com.google.common.base.Throwables; | ||
| import org.rocksdb.RocksDBException; | ||
|
|
||
| /** | ||
| * RocksDB implementation of the local KV storage used to persist the shuffle state. | ||
| */ | ||
| public class RocksDB implements DB { | ||
| private final org.rocksdb.RocksDB db; | ||
|
|
||
| public RocksDB(org.rocksdb.RocksDB db) { | ||
| this.db = db; | ||
| } | ||
|
|
||
| @Override | ||
| public void put(byte[] key, byte[] value) { | ||
| try { | ||
| db.put(key, value); | ||
| } catch (RocksDBException e) { | ||
| throw Throwables.propagate(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public byte[] get(byte[] key) { | ||
| try { | ||
| return db.get(key); | ||
| } catch (RocksDBException e) { | ||
| throw Throwables.propagate(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void delete(byte[] key) { | ||
| try { | ||
| db.delete(key); | ||
| } catch (RocksDBException e) { | ||
| throw Throwables.propagate(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public DBIterator iterator() { | ||
| return new RocksDBIterator(db.newIterator()); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| db.close(); | ||
| } | ||
| } |
95 changes: 95 additions & 0 deletions
95
common/network-common/src/main/java/org/apache/spark/network/shuffledb/RocksDBIterator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.network.shuffledb; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.AbstractMap; | ||
| import java.util.Map; | ||
| import java.util.NoSuchElementException; | ||
|
|
||
| import com.google.common.base.Throwables; | ||
| import org.rocksdb.RocksIterator; | ||
|
|
||
| /** | ||
| * RocksDB implementation of `DBIterator`. | ||
| */ | ||
| public class RocksDBIterator implements DBIterator { | ||
|
|
||
| private final RocksIterator it; | ||
|
|
||
| private boolean checkedNext; | ||
|
|
||
| private boolean closed; | ||
|
|
||
| private Map.Entry<byte[], byte[]> next; | ||
|
|
||
| public RocksDBIterator(RocksIterator it) { | ||
| this.it = it; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasNext() { | ||
| if (!checkedNext && !closed) { | ||
| next = loadNext(); | ||
| checkedNext = true; | ||
| } | ||
| if (!closed && next == null) { | ||
| try { | ||
| close(); | ||
| } catch (IOException ioe) { | ||
| throw Throwables.propagate(ioe); | ||
| } | ||
| } | ||
| return next != null; | ||
| } | ||
|
|
||
| @Override | ||
| public Map.Entry<byte[], byte[]> next() { | ||
| if (!hasNext()) { | ||
| throw new NoSuchElementException(); | ||
| } | ||
| checkedNext = false; | ||
| Map.Entry<byte[], byte[]> ret = next; | ||
| next = null; | ||
| return ret; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| if (!closed) { | ||
| it.close(); | ||
| closed = true; | ||
| next = null; | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void seek(byte[] key) { | ||
| it.seek(key); | ||
| } | ||
|
|
||
| private Map.Entry<byte[], byte[]> loadNext() { | ||
| if (it.isValid()) { | ||
| Map.Entry<byte[], byte[]> nextEntry = | ||
| new AbstractMap.SimpleEntry<>(it.key(), it.value()); | ||
| it.next(); | ||
| return nextEntry; | ||
| } | ||
| return null; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.