816 layouts for reflexion modeling #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut is selected.
…ure. Configured these new parameters.
Added tool tips. Added readonly where possible.
…lexion-modeling # Conflicts: # Assets/SEE/Tools/Livekit/LivekitVideoManager.cs # Packages/packages-lock.json # ProjectSettings/ProjectVersion.txt
…lexion-modeling # Conflicts: # Assets/SEE/Game/City/SEEReflexionCity.cs # Assets/SEE/Game/CityRendering/GraphRenderer.cs # Assets/Scenes/SEENewWorld.unity
All other things are still work in progress.
Removed references to removed Cose Layout. Split ILayoutNode.cs into separate files.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Cyclone1337
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Thank you for this really useful feature.
I really like the customization options, such as the size of the architecture and the paddings, etc. However, I think the default should be that there is some space between the two subgraphs (Implementation / Architecture) to allow selecting the main root. For example, to execute a delete action.
Unfortunately, I noticed that this feature is not yet displayed correctly in the RuntimeConfigMenu. There, regardless of the selected node layout setting kind, Architecture and Implementation are always visible and selectable.
Simplified new(). Added readonly.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…not work anyway.
New node types ARCHITECTURE, ROOT, and IMPLEMENTATION. Cose Layout was removed.
The introduction of ReflexionNodeLayout has introduced new attributes.
Simplified RootGameNode(). Improved documentation.
…remen-agst/SEE into 816-layouts-for-reflexion-modeling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new nested layout for the reflexion analysis where a user can select one layout for the implementation and another layout for the architecture.
To achieve that, the user needs to select "Reflexion" from node-layout menu. The two new sub-menus show up and the user can select the layout for the implementation and architecture, respectively.
It should be noted that the first and original data path relates to the implementation if "From File" was selected as a node layout for the implementation. The architecture layout data path (the second and new one) relates to the architecture.
To enable that this nested layout, a substantial refactoring of the layouts was necessary.:
In addition, the Cose layout was removed. We have never really used it and it was declared as deprecated. Likewise, Manhattan layout was removed. It is not hierarchical and makes little sense. It existed only because it was the very first layout implemented to get things going.
Additional unrelated changes: