Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different layouts for architecture and implementation in reflexion modeling needed #816

Closed
koschke opened this issue Jan 8, 2025 · 0 comments · Fixed by #824
Closed
Assignees
Labels
enhancement New feature or request

Comments

@koschke
Copy link
Collaborator

koschke commented Jan 8, 2025

Currently, a layout is computed for a reflexion graph consisting of both the implementation and the architecture. As a result, a stored manual layout for the architecture cannot be loaded and we have no control over the space for either of the implementation and the architecture subgraph. The latter can cause an architecture layout to become too small to move implementation nodes onto architecture nodes during the manual mapping process.

We want allow a user to

  • assign different layouts to the architecture and implementation graphs
  • decide the proportion of space available allocated for each of the layouts
@koschke koschke added the enhancement New feature or request label Jan 8, 2025
@koschke koschke self-assigned this Jan 8, 2025
koschke added a commit that referenced this issue Jan 8, 2025
koschke added a commit that referenced this issue Jan 8, 2025
koschke added a commit that referenced this issue Jan 8, 2025
koschke added a commit that referenced this issue Jan 28, 2025
koschke added a commit that referenced this issue Jan 29, 2025
All other things are still work in progress.
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
Removed references to removed Cose Layout.
Split ILayoutNode.cs into separate files.
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
Simplified new. Added reference to Wettel's dissertation where the
algorithm comes from.
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 3, 2025
koschke added a commit that referenced this issue Feb 10, 2025
ILayoutNode has an implementation of IHierarchyNode.
AbstractLayoutNode does no longer need the mapping ToLayoutNode.
Clients can (and need) to call AddChild to establish the node hierarchy.
koschke added a commit that referenced this issue Feb 10, 2025
koschke added a commit that referenced this issue Feb 11, 2025
The previous implementation let the LoadedNodeLayout fail because the
ID was not set. We need to retrieve it from the game objects.
koschke added a commit that referenced this issue Feb 11, 2025
This way the naming is consistent with the edge layouts.
koschke added a commit that referenced this issue Feb 11, 2025
koschke added a commit that referenced this issue Feb 11, 2025
for the layout. The ReflexionLayout needs that.
koschke added a commit that referenced this issue Feb 11, 2025
We have never truly made a distinction.
koschke added a commit that referenced this issue Feb 11, 2025
Should have been architectureArea.
Removed debugging code.
Removed unecessary prefix System for Exception.
Removed obsolete code that was commented out.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke koschke linked a pull request Feb 12, 2025 that will close this issue
koschke added a commit that referenced this issue Feb 12, 2025
koschke added a commit that referenced this issue Feb 12, 2025
koschke added a commit that referenced this issue Feb 12, 2025
koschke added a commit that referenced this issue Feb 12, 2025
koschke added a commit that referenced this issue Feb 18, 2025
Simplified new(). Added readonly.
koschke added a commit that referenced this issue Feb 20, 2025
koschke added a commit that referenced this issue Feb 20, 2025
New node types ARCHITECTURE, ROOT, and IMPLEMENTATION.
Cose Layout was removed.
koschke added a commit that referenced this issue Feb 20, 2025
koschke added a commit that referenced this issue Feb 20, 2025
koschke added a commit that referenced this issue Feb 20, 2025
The introduction of ReflexionNodeLayout has introduced new attributes.
koschke added a commit that referenced this issue Feb 20, 2025
Simplified RootGameNode().
Improved documentation.
koschke added a commit that referenced this issue Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant