Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different layouts for architecture and implementation in reflexion modeling needed #816

Closed
koschke opened this issue Jan 8, 2025 · 0 comments · Fixed by #824
Closed

Different layouts for architecture and implementation in reflexion modeling needed #816

koschke opened this issue Jan 8, 2025 · 0 comments · Fixed by #824
Assignees
@koschke
Labels
enhancement New feature or request

Comments

@koschke
Copy link
Collaborator

koschke commented Jan 8, 2025

Currently, a layout is computed for a reflexion graph consisting of both the implementation and the architecture. As a result, a stored manual layout for the architecture cannot be loaded and we have no control over the space for either of the implementation and the architecture subgraph. The latter can cause an architecture layout to become too small to move implementation nodes onto architecture nodes during the manual mapping process.

We want allow a user to

  • assign different layouts to the architecture and implementation graphs
  • decide the proportion of space available allocated for each of the layouts
@koschke koschke added the enhancement New feature or request label Jan 8, 2025
@koschke koschke self-assigned this Jan 8, 2025
koschke added a commit that referenced this issue Jan 8, 2025
@koschke
#816 Settings for incremental tree-map layout shown only if that layo…
42337c8 
…ut is selected.
koschke added a commit that referenced this issue Jan 8, 2025
@koschke
#816 Removed unused imports.
696331e
koschke added a commit that referenced this issue Jan 8, 2025
@koschke
#816 The user can now select a separate node layout for the architect…
db272d5 
…ure.
koschke added a commit that referenced this issue Jan 8, 2025
@koschke
#816 The user can now select a separate node layout for the architect…
1ce811c 
…ure.

Configured these new parameters.
koschke added a commit that referenced this issue Jan 20, 2025
@koschke
#816 Working on calculating two separate layouts. Work in progress.
9347114
koschke added a commit that referenced this issue Jan 28, 2025
@koschke
#816 Re-Draw button only shown when graph is drawn.
611fdb1
koschke added a commit that referenced this issue Jan 28, 2025
@koschke
#816 More informative exception.
40971f3
koschke added a commit that referenced this issue Jan 28, 2025
@koschke
#816 We will now wait less for a dashboard response.
6991bf3
koschke added a commit that referenced this issue Jan 29, 2025
@koschke
#816 Calculating the areas for implmentation and architecture works.
464f675 
All other things are still work in progress.
koschke added a commit that referenced this issue Jan 30, 2025
@koschke
#816 Renamed parameters. Added documentation.
d85fcd6
koschke added a commit that referenced this issue Jan 30, 2025
@koschke
#816 Improved documentation. Renamed parameter.
217201b
koschke added a commit that referenced this issue Jan 30, 2025
@koschke
#816 Improved documentation. Removed documentation of removed paramter.
e97c75d
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Removed unused import.
5896bbd
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Removed unused import.
4b6f477
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Improved documentation.
cfc4a3b
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Removed Cose Layout.
f60f7df
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Changed API of node layouts: rectangle parameter added.
f03704f 
Removed references to removed Cose Layout.
Split ILayoutNode.cs into separate files.
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Removed CoseGraphSettings. Added new table CloneCity. Moved Dyna…
2e15dba 
…micTable.
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Settings for Network Linux subsystem (clone information).
730aeb8
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Removed AddCloneEdges(). Was introduced only for a VISSOFT publi…
4f7afed 
…cation.
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Simplified new.
c5433c7
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Documentation makes clear position and scale are worldspace.
2c778ff
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Simplified new.
3e70593
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Added Print() for debugging.
6220eb2
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Fixed wrong calulation of "ratio closest to 1".
c1eab15 
Simplified new. Added reference to Wettel's dissertation where the
algorithm comes from.
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 expanders has now the absolute difference of the aspect ratio fr…
c304ee1 
…om 1.

This simplifies the comparison.
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 Fixed comment.
58db5d5
koschke added a commit that referenced this issue Feb 3, 2025
@koschke
#816 ScaleBy renamed to ScaleXZBy. ScaleXZBy scales only X/Z co-ordin…
7b09755 
…ates.
koschke added a commit that referenced this issue Feb 10, 2025
@koschke
#816 Restructured inheritance hierarchy of ILayoutNode.
1df6779 
ILayoutNode has an implementation of IHierarchyNode.
AbstractLayoutNode does no longer need the mapping ToLayoutNode.
Clients can (and need) to call AddChild to establish the node hierarchy.
koschke added a commit that referenced this issue Feb 10, 2025
@koschke
#816 Removed unused import.
9e54732
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Fixed implementation of ID.
8827bb4 
The previous implementation let the LoadedNodeLayout fail because the
ID was not set. We need to retrieve it from the game objects.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Renamed NodeLayout.GetLayout to Create.
4ca82c6 
This way the naming is consistent with the edge layouts.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Fixed indentation.
c0b87ad
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Added IHiearchyNode.RemoveChild so that we can modify the hierarchy
fbd3b03 
for the layout. The ReflexionLayout needs that.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Fixed x co-ordindate of root NodeTransform. Must be x. Was y.
615bd76
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Merged IGameNode.AbsoluteScale and LocalScale into one.
36373ac 
We have never truly made a distinction.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Fixed actual parameter to rchitectureLayout.Create.
6c99112 
Should have been architectureArea.
Removed debugging code.
Removed unecessary prefix System for Exception.
Removed obsolete code that was commented out.
koschke added a commit that referenced this issue Feb 11, 2025
@koschke
#816 Removed unused method.
40a3513
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 The settings for a reflexion layout are now passed to the layout.
6ad2424
@koschke koschke linked a pull request Feb 12, 2025 that will close this issue
816 layouts for reflexion modeling #824
Merged
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 Added an issue for the FIXME.
f572688
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 Added documentation.
9ac27c0
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 Added documentation.
329b090
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 Added documentation for type parameter.
fca98c2
koschke added a commit that referenced this issue Feb 12, 2025
@koschke
#816 Added documentation.
0f6df6f
koschke added a commit that referenced this issue Feb 18, 2025
@koschke
#816 Removed unused parameter groundLevel.
cb3b42a 
Simplified new(). Added readonly.
koschke added a commit that referenced this issue Feb 18, 2025
@koschke
#816 Fixed minor issues mentioned in the code review.
90337cb
koschke added a commit that referenced this issue Feb 18, 2025
@koschke
#816 Fixed issues noted in the code review.
14f7eab
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Removed parameter doNotAddUniqueRoot.
f5a4136
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Reverted comment style. The <paramref name="layoutNodes"/> will …
c15daf8 
…not work anyway.
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Reflexion Layout is used.
986c89f 
New node types ARCHITECTURE, ROOT, and IMPLEMENTATION.
Cose Layout was removed.
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Fixed typo.
85d4f54
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 A unique root should not be added.
9d26d2c
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Reflexion Layout is used for ReflexionCity.
a57e894 
The introduction of ReflexionNodeLayout has introduced new attributes.
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Re-introduced parameter doNotAddUniqueRoot.
446c14f 
Simplified RootGameNode().
Improved documentation.
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Improved documentation.
62b71a9
koschke added a commit that referenced this issue Feb 20, 2025
@koschke
#816 Better names for initially generated architecture and implementa…
e1502de 
…tion nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koschke koschke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

816 layouts for reflexion modeling uni-bremen-agst/SEE
1 participant
@koschke