Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #22

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Docs #22

merged 9 commits into from
Apr 22, 2024

Conversation

imperosol
Copy link
Collaborator

Imagine il y a un projet de l'UNG qui est documenté.

Non je déconne.

Mais imagine quand même.

@imperosol imperosol requested a review from Zalk0 April 10, 2024 12:16
@imperosol
Copy link
Collaborator Author

rebase

@imperosol imperosol force-pushed the docs branch 3 times, most recently from ebb91b7 to 3a0a4db Compare April 15, 2024 11:33
@imperosol
Copy link
Collaborator Author

Ca devrait être bon.

Par contre, pre-commit dit :

could not determine a constructor for the tag 'tag:yaml.org,2002:python/name:material.extensions.emoji.twemoji'
  in "mkdocs.yaml", line 89, column 20

Mais c'est dans la doc officielle : https://squidfunk.github.io/mkdocs-material/reference/icons-emojis/
Donc bon 🤷

@imperosol imperosol requested a review from Zalk0 April 15, 2024 11:35
Copy link
Collaborator

@Zalk0 Zalk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça m'a l'air pas mal, j'ai fait des modifs directement plutôt que de review parce que ça aurait fait beaucoup de commentaires 😂

- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 3.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pourrait presque mettre 3.x vu que c'est pour générer la doc

- add Scoop install method for Windows
- add PPA for Python on Ubuntu
- add last web server response to user to say if the roles were attributed correctly
- add mention of languages other than Python in naming conventions

And various fixes:
- forgotten upper case at beginning of names
- bump required Python version to 3.10
- fix some notes
- fix image links (must be relatives as per the mkdocs doc)
- fix home page not being in nav
- .yml to .yaml
- indentation in mkdocs.yaml and docs.yaml
@imperosol imperosol merged commit a71e0f0 into main Apr 22, 2024
3 checks passed
@Zalk0 Zalk0 deleted the docs branch April 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants