Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Feature/Search alignments 3.3.1 #7408

Open
wants to merge 102 commits into
base: release-v3.3.1
Choose a base branch
from
Open

WIP: Feature/Search alignments 3.3.1 #7408

wants to merge 102 commits into from

Conversation

PhotoNomad0
Copy link
Contributor

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

@PhotoNomad0
update wa tool
e471b32
@PhotoNomad0
adding search
979d830
@PhotoNomad0
Merge branch 'release-v3.3.0' into feature-mcleanb-save-alignmentMemory
0cac347
@PhotoNomad0
building search dialog
c5a7cfd
@PhotoNomad0
showing results in table
7af63cf
@PhotoNomad0
fix icons in table
b594cc3
@PhotoNomad0
fix font size in table
86d2471
@PhotoNomad0
fix for testament switch
4eaa9d7
@PhotoNomad0
added strongs numbers and search options
949898f
@PhotoNomad0
added multi-select for search fields
040196f
@PhotoNomad0
removed paging
b03a9af
@PhotoNomad0
tweak strings
4e0775c
@PhotoNomad0
update tools with latest locale
0c9d449
@PhotoNomad0
tweak seach prompts
b260000
@PhotoNomad0
add extraction of alignment data
79ad806
@PhotoNomad0
add extraction of alignment data
acc2241
@PhotoNomad0
add extraction of alignment data
09a832d
@PhotoNomad0
add extraction of alignment data
1f86e9b
@PhotoNomad0
work on indexing downloaded aligned bibles
3f024d1
@PhotoNomad0
work on indexing downloaded aligned bibles
b26b0c4
@PhotoNomad0
work on selecting aligned bibles to search
3533a11
@PhotoNomad0
fixing search to work with downloaded resources
94b780c
@PhotoNomad0
update CHANGELOG.md
c07bba8
@PhotoNomad0
fix tests
91b5fb0
@PhotoNomad0
Merge remote-tracking branch 'origin/release-v3.3.0' into feature-mcl…
620e3e8 
…eanb-save-alignmentMemory

# Conflicts:
#	package-lock.json
@PhotoNomad0
fix unit tests
e9be15f
@PhotoNomad0
udpate comments and clean up busy dialogs
664a4d7
@PhotoNomad0
add progress on alignment indexing for search.
bb55a2c
@PhotoNomad0
updated README.md
18f99c7
@PhotoNomad0
updated README.md
4f93e9f
@PhotoNomad0 PhotoNomad0 mentioned this pull request Oct 11, 2022
Merged
16 tasks
@PhotoNomad0
Copy link
Contributor Author

migrated changes to #7440

@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature/Search alignment memory WIP: Feature/Search alignments Oct 15, 2022
@PhotoNomad0 PhotoNomad0 reopened this Oct 15, 2022
@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature/Search alignments WIP: Feature/Search alignments 3.3.1 Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PhotoNomad0