Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated wordmap #6515

Merged

Conversation

da1nerd
Copy link
Contributor

@da1nerd da1nerd commented Oct 29, 2019

Describe what your pull request addresses (Please include relevant issue numbers):

Related to #6237

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

@da1nerd da1nerd self-assigned this Oct 29, 2019
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #6515 into release-v2.1.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v2.1.0    #6515   +/-   ##
===============================================
  Coverage           60.51%   60.51%           
===============================================
  Files                 278      278           
  Lines               10376    10376           
  Branches             1698     1698           
===============================================
  Hits                 6279     6279           
  Misses               3647     3647           
  Partials              450      450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdeb06...e74d924. Read the comment docs.

@da1nerd da1nerd marked this pull request as ready for review November 6, 2019 13:00
@da1nerd
Copy link
Contributor Author

da1nerd commented Nov 7, 2019

@PhotoNomad0 I would suggest merging this in for now. There have been so many fixes and different corner cases it's difficult to keep track of everything. If we can get some people testing this and write up any problems in a brand new issue that would help my sanity 😄

Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @neutrinog)

@PhotoNomad0 PhotoNomad0 merged commit 0d39f10 into release-v2.1.0 Nov 7, 2019
@da1nerd da1nerd deleted the enhancement/joel/6237/wordmap-occurrence-bug branch November 15, 2019 09:26
PhotoNomad0 added a commit that referenced this pull request Dec 27, 2019
* New translations English-en_US.json (Bengali, India)
[ci skip]

* New translations English-en_US.json (Bengali, India)
[ci skip]

* New translations English-en_US.json (Bengali, India)
[ci skip]

* New translations English-en_US.json (Bengali, India)
[ci skip]

* New translations English-en_US.json (Bengali, India)
[ci skip]

* Update repos via translationCore Submodule Updater

* added updates from comments

* added fall back for no getProgress implementation

* removed tool commit

* package-lock.json

* package-lock.json

* Refactor - #6444 - TranslationHelpsWrapper (#6474)

* WIP - Refactor - #6444 - TranslationHelpsWrapper

* Update checking tool wrapper

* Version bump for checking-tool-wrapper

* toolName is default to null

* Refactored VerseCheckWrapper, GroupMenuWrapper & ScripturePaneWrapper (#6470)

* testing

* Rolled back changes to src/js/pages/app.js

* Updated actions to not need the usernmae as parameter

* Fixed unit tests

* Added [email protected]

* package-lock.json

* package-lock.json

* [email protected]

* Fixed lexicon popovers: Added [email protected] & [email protected]

* WIP - Refactor - #6445 - CheckInfoCardWrapper (#6475)

* WIP - Refactor - #6445 - CheckInfoWrapper

* Update

* Updates

* updated checking-tool-wrapper

* merged changes from 3579.2 into dev.

* package-lock.json

* Edit Verse Checking Performance Imporovement (#6480)

* added checking tool wrapper and tc-ui-tool-kit changes

* updated package.json

* updated checking-tool-wrapper.

* updated checking-tool-wrapper.  Fix for updating group menu data

* clear check data on contextId change

* update checking-tool-wrapper

* added sanity check

* Added fix for blank screen on tool reselect (#6483)

* added fix for blank screen on tool reselect

* fixed tests

* added fix for clearing tool data on gl select

* fixed tests

* updated checking-tool-wrapper

* update checking-tool-wrapper

* added sanity check

* removing comments

* changeCurrentContextId() changed to load data from group menu reducer if found

* changeCurrentContextId() changed to load data from group menu reducer if found

* changeCurrentContextId() changed to load data from group menu reducer if found

* Added lagtest tc-tool

* merged w/ dev

* Removed commented code

* backed out async load changes for changeCurrentContextId() when group data is not in reducer.

* Fixed unit tests

* [email protected]

* package-lock.json

* New translations English-en_US.json (Marathi)
[ci skip]

* New translations English-en_US.json (Marathi)
[ci skip]

* performance tweaks for updating group data with latest settings.

* more tests, cleanup

* fixes for nothingToSelect

* fixes for tool progress to not show 100% if any checks missing and to show '<1%' if progress is between 0 and 1%.

* Latest tc-tool

* [email protected]

* fixed typo

* Fixed typo

* checking-tool-wrapper now has its own redux store (#6484)

* testing

* Rolled back changes to src/js/pages/app.js

* Updated actions to not need the usernmae as parameter

* Fixed unit tests

* Refactor out popover action

* Temp removed logger

* tESTING CHECKING-TOOL-WRAPPER BRANCH

* package-lock.json

* package-lock.json

* package-lock.json

* Added lagtest tc-tool

* merged w/ dev

* Removed commented code

* Fixed unit tests

* [email protected]

* package-lock.json

* Latest tc-tool

* [email protected]

* fixed typo

* Fixed typo

* Update repos via translationCore Submodule Updater

* fixing repo links

* Manually added latest commit hash for tools

* Update repos via translationCore Submodule Updater

* Bugfix 6430/User is not warned when Create New Repo or Rename repo functions fail (#6494)

* remove recursion in rename error prompting.

* remove recursion in rename error prompting.

* remove recursion in rename error prompting.

* added logging for debugging

* fix unit tests

* fix unit tests

* fix continue after error

* fix repo name parsing.  Fix create new prompts. remove recursion from handleDcsRenameCollision()

* fix to support project name change

* add waits for screen updates

* add waits for screen updates

* removing unneeded delays.  Andding upload status dialog

* fix upload status dialog

* moving actions from ProjectDetailsHelpers to ProjectDetailsActions

* updated tCore version and updated unit tests.

* removed old snapshots.

* fix for parsing git URLs. Some more refactoring.

* Some more refactoring.

* unit test fixes

* unit test fixes

* fix for empty selection

* fix to only save most recent selections in selections.csv. Updated unit tests

* fix for reminders to only save the most recent if set.  Added unit tests.

* updated wordmap to fix wrong occurrence suggestion (#6502)

* fix issue that old dialog was left on screen during rename.  Added status to show that we are renaming on DCS.

* update snapshot

* add delay to update UI

* add delay to update UI

* doDcsRenamePrompting - removed change git to point to new repo always which caused errors - the create and rename operations will do that when successful. A few changes to return values

* after DCS rename or create new, now pushes latest changes up to D43

* fix unit tests

* changed to reprompt DCS repo choice if user changes changes translation ID.

* fix for automatic behavior that changing translation id closed project

* fix for automatic behavior that changing translation id closed project

* fix unit test

* cleanup

* updated checking-tool-wrapper with fix for `no_selection_needed` on grouped menu filter

* fix logic error where if newer original bible resource present, end up with empty bible folder.

* fix required versions sort.

* fix unit test

* fix to make sure current resource is installed.  fix fs.copySync mock for directories. Fix for extractZippedResourceContent where multiple versions in directory.

* fix fs.copySync mock for directories.

* logging.

* test build

* test build

* test build - updated dependencies.

* Moves all DCS URL references to a constant (#6524)

* Update repos via translationCore Submodule Updater

* Update repos via translationCore Submodule Updater

* Update repos via translationCore Submodule Updater

* Updated .gitmodules

* Update repos via translationCore Submodule Updater

* Just a whitespace edit to kickoff concourse

* Moves all DCS URL references to a constant

* Puts constant in the right place

* Two fixes per PR review

* update snapshot

* updated dependencies.

* updated dependencies.

* fix for missing token.

* fix to close project on upload.

* test build

* updated dependencies.

* updated wordmap (#6515)

* updated wordmap

* bumped wordmap version

* updated wordmap

* updated wordmap

* Converted lhandleDcsRenameCollisionPromise to use callbacks. fixed unit tests.

* fix lint.

* Revert "fix lint."

This reverts commit 22ab4ef

* Revert "Converted lhandleDcsRenameCollisionPromise to use callbacks. fixed unit tests."

This reverts commit 654f902

* Revert "Converted lhandleDcsRenameCollisionPromise to use callbacks. fixed unit tests."

This reverts commit 654f902

* cleaup

* updated tc-ui-toolkit and checking-tool-wrapper

* cleaup

* updated dependencies

* updated dependencies

* fix to update language list after updating source content.

* updated checking-tool-wrapper

* first attempt at unit tests.

* reverted first attempt at unit tests.

* added redraw of busy on project open if

* fix to close alert dialog when project open is finished

* cleanup

* fix unit tests

* fix to prevent double push to DCS

* crowdin updates

* removed callback from reducer.

* cleanup

* moved git save operation into renameRepo() and createNewRepo() - git save is done before push so that we have latest manifest changes.

* cleanup.

* fix unit tests.

* fix unit tests.

* updated dependencies

* cleanup

* updated tc-ui-toolkit and checking-tool-wrapper

* fix move of .git to overwritten project

* merge locale updates from develop.

* updated wordmap (#6557)

* added parameter to select async file loading on loadResourceArticle().

* updated dependencies

* updated tsv-groupdata-parser for testing

* updated dependencies

* locale updated

* updated dependencies

* updated dependencies

* updated wa

* test build

* updated dependencies

* Updated tools

* revert wordmap to tC 2.0.0

* testing

* updated bundled resources.

* minimal bundled.

* testing

* updated dependencies.

* updated dependencies.

* updated dependencies.

* updated dependencies.

* updated dependencies.

* updated tools with locale strings updated

* updated tools with locale strings updated

* testing

* testing

* cleanup

* updated dependencies

* update tN with locale updates

* updated dependencies

* updated dependencies

* updated dependencies

* updated change log

* testing

* updated dependencies

* fix crash when search api returns empty message rather than array of repos

* fix crash when search api returns empty message rather than array of repos

* fix problem that after upload of selected project, user is stuck with project selected and tools disabled.

* On upload add invalid login message on 401 error.
For login, on token match only match tokens that have sha1.
On user card add warning on invalid user token.

* Add support if resource folder is empty.

* Add unit tests for empty user resource folders

* Fix for local user - don't prompt with invalid login.
Moved up minCompatibleVersion to 2.1.0.

* Restored minCompatibleVersion to 2.0.0.

* Moved up minCompatibleVersion to 2.1.0.

* Updated CHANGELOG.md for release-v2.1.0 (#6610)

* updated CHANGELOG.md

* updated CHANGELOG.md

* Update Change log (#6617)

* updated CHANGELOG.md

* updated CHANGELOG.md

* updated CHANGELOG.md

* Update Release 2.1.0 change log (#6618)

* updated CHANGELOG.md

* updated CHANGELOG.md

* updated CHANGELOG.md

* updated CHANGELOG.md

Co-authored-by: Manny Colon <[email protected]>
Co-authored-by: Sterling (Jay) Scott <[email protected]>
Co-authored-by: Richard Mahn <[email protected]>
Co-authored-by: Jesse Griffin <[email protected]>
Co-authored-by: Joel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants