Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 533/speedup saving #156

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Feature 533/speedup saving #156

merged 4 commits into from
Sep 13, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Sep 13, 2023 •
edited
Loading

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review September 13, 2023 18:14
kintsoogi
kintsoogi approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tested the psalm save back to back, and the save was a few seconds faster

@PhotoNomad0 PhotoNomad0 merged commit ba59861 into master Sep 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kintsoogi kintsoogi kintsoogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotoNomad0 @kintsoogi