Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor to single page #24
Feature/refactor to single page #24
Changes from 31 commits
c2e67c2
75d0fbb
3096890
5c2f7e0
ce96c63
721abc6
ea6bbe6
50ed3de
8ff042d
ec60d02
d018b38
ccc9ded
3d1cc0c
ba39d0c
58e34b7
9a3901a
3ec3d7c
79f1a27
35cdf8b
c7df4d0
5237250
9c44ef0
21ff464
0a94426
69918a3
6724cd1
7ba3486
5084198
0490725
0ebf6fa
63d796a
3612259
918bf6e
934ae8f
d453855
caecdc6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could extract this into a serialiser to improve the readability of the controller.
If not the whole hash, at least the
map
key seems the most suitable part for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Levia my first serializer - be gentle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 🤔 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use
map
instead ofeach
so you won't need to returntargets
at the end.map
returns the modified array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i don't return targets, it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see the point now. That's fine then!
This file was deleted.