Skip to content

Commit

Permalink
hotfix: remove download: true from global statistics download link
Browse files Browse the repository at this point in the history
  • Loading branch information
@stanleypliu
stanleypliu committed Jun 8, 2021
1 parent c58e064 commit a4ebde2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion app/views/global/_downloads.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
<% else %>
<%= link_to downloads[:statistics][:button], "downloads/global_statistics.zip",
class: 'downloads__button button--download',
download: true,

This comment has been minimized.

Sign in to view

Copy link
@WKocur

WKocur Jun 8, 2021

Contributor

@stanleypliu Can we change this to the name of the file that you want it to download as (sorry didn't realise it would set the file name...). The analytics tracking looks for the download attribute in order to track so it needs to have one currently.

This comment has been minimized.

Sign in to view

Copy link
@stanleypliu

stanleypliu Jun 8, 2021

Author Contributor

Yeah sure, I can set this to global_statistics

This comment has been minimized.

Sign in to view

Copy link
@WKocur

WKocur Jun 8, 2021

Contributor

Thanks!
data: {
download_type: 'statistics',
download_label: 'global'
Expand Down

0 comments on commit a4ebde2

Please sign in to comment.