(fix) issue #1375 -- header size dynamically adjusted #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the header is computed with a mathematical function and passed further to react. This way the header does not wrap around for single words that are long. However, it still wraps around for phrases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 (fix) issue #1375 -- header size dynamically adjusted
Issue
"The size of the header is computed with a mathematical function and passed further to react. This way the header does not wrap around for single words that are long. However, it still wraps around for phrases."
Solution
With this PR, the size of the header is computed with a mathematical function and passed further to react. This way, the header does not wrap around for long single words; the functionality of text wrapping around for phrases is still maintained.
See appendix below.
Type of Change
This activity is supported by the Network Institute, Vrije Universiteit Amsterdam, under the Code for Humanity initiative.
Appendix
Initially
Text from template
4 letter word (<5 threshold)
>=5 letter-threshold
14 letter word (3% of the English words have >=letters, 0.02% have >=14 letters)
A bit towards extreme
"ABCDE FGHIJKLM NOPQRSTU" (3 longer words)