-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mc button #46
Open
MCaldwell-42
wants to merge
25
commits into
undergroundjs:master
Choose a base branch
from
nashvillefcc:mc_button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mc button #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex page Also add a plug-in for handling svgs in gastby and react-feather Add a svgs folder to hold all the svgs images plus the gatsby needs to a stand alone directory react-feather was already using used in the old theme but on it's a main package Additions to the index page include Speakers, Venue and Sponsors sections along with a call to action for Sponsors or Volunterrs
Add the following pages: - contact - schedule - speakers
Reviewed and approved. Mirgated most of the site to scss rather than react styles
Reviewed and approved Readme update
Add a content about Branches, Pull Request, How to contact, what should I know
Add the folowing assists: - ugjs-skyline.svg - map-pin.png - ninja.png - superhero.png - twitter-icon.png - ugjs-logo-large.png - ugjs-logo-sm.png - ugjs-logo-sm-color.png
Add Images to project
Add the fonts, color to _Base SCSS file
Ticket #14 contributing update
Added Helmet Plugin and Fonts using SASS imports - Checked and approved -- this is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nashvillefcc#23
Here is a link to the issue. other than the style modes it is also set up to be dynamic based on what the button says allowing some deviation, while still taking users to the correct link.
@Hellrungj it doesn't appear I can assign reviewers so here is a tag.
This PR is set to merge to master and I'm a bit confused by code repo and issues repo but...trusting y'all have it sorted.