-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added content to the Sponsorship/Prospectus Page #38
base: master
Are you sure you want to change the base?
Conversation
>> - Added Limited to Row >> - Added A La Carte Sponsorship Options Table >> - Added Limited to row >> - Added Branding in conference media >> - Added Branding on t-shirt >> - Added Conference ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for working on this! I left some comments with some thoughts I had. Much appreciated.
src/pages/become-a-sponsor.js
Outdated
∞ | ||
</span> | ||
</td> | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would rather have them reach out or we cross of the row when sold out than to display the counts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove this row then. And we can add a call to action elsewhere.
src/pages/become-a-sponsor.js
Outdated
@@ -104,7 +104,7 @@ export default () => { | |||
<thead> | |||
<tr> | |||
<th>Benefit</th> | |||
<th css={styles.highlight}>Platinum (Limit 1)</th> | |||
<th css={styles.highlight}>Platinum</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving limit one here may be better than listing limits on all of them.
src/pages/become-a-sponsor.js
Outdated
@@ -248,6 +271,150 @@ export default () => { | |||
</tbody> | |||
</table> | |||
|
|||
<Styled.h3>A La Carte Sponsorship Options</Styled.h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section replaces the Exclusive Sponsorship options
, so we should probably remove it: https://github.com/undergroundjs/website/pull/38/files#diff-c0a411ccae889ddca60b183f7439007fR90-R100
src/pages/become-a-sponsor.js
Outdated
</span> | ||
</td> | ||
<td> | ||
<span role="img" aria-label="Benefit included"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the aria-label is only needed to wrap the emoji so those using a screenreader know what the check means. We should remove it in the cases where it is wrapping a number because it will override the number and it will lose meaning.
Added Limit 1 to the Platinum Cal Heading Removed A La Carte Sponsorship Option Table Update the numbers in the table to not include image span
Updated the Sponsorship/Prospectus Page. |
I am good with this as is for now. Can we add a link to this in the footer. |
Update prospectus for 2020 #35 Update prospectus for 2020