-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
About: Move presentations (pdf/ppx) to end of about. Embed Vid. (#242)
Note: Feel free to ignore this - just documenting my own experience with suggestions that would have improved it. When I started reading about UNTP on the about page, I loved the first paragraph, then headed for the next link, the short presentation. Reading the short presentation without any other background caused me to spend a lot of time trying to parse the info and diagrams without a lot of context. If I'd first watched the video (even though I normally prefer to read - I could have also read below) the same information would have been presented with a lot more context. So... this PR does 3 things: 1. Moves the "Presentations & Videos" section to the end (more relevant after reading the about if I then want to use the presentation info, not so useful without more context), but 2. Keeps the video intro (which was an excellent intro) prominent at the start, by adding a <YouTube> react component so that the reader is lead straight to it (but can scroll past of course) 3. Lastly, my editor has just removed some trailing white-space. ![image](https://github.com/user-attachments/assets/bf875563-bee5-4d0a-8c2a-b74aacb7f966)
- Loading branch information
1 parent
202a487
commit a98d272
Showing
2 changed files
with
28 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import React from "react"; | ||
|
||
export const YouTube = ({ id, }) => ( | ||
<div> | ||
<iframe | ||
style={{ width: '100%', aspectRatio: '16/9' }} | ||
src={"https://www.youtube.com/embed/" + id} | ||
title="YouTube Video Player" | ||
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" | ||
></iframe> | ||
</div> | ||
); | ||
|
||
export default YouTube; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters