Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): correct Options type #175

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

marcalexiei
Copy link

@marcalexiei marcalexiei commented Nov 2, 2024

Refine extensions rule Options:

  • since the function used by the rule to get file extension is called is called getModifier I renamed all relevant information using modifier name.
  • Refined Options with more explicit array types
  • Changed buildProperties checks to avoid type checking errors

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: d78d9da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SukkaW SukkaW merged commit acebd98 into un-ts:master Nov 10, 2024
21 checks passed
@marcalexiei marcalexiei deleted the extensions-options-type branch November 13, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants