New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON files fixed issue #62 #65

Closed

ghost wants to merge 1 commit into umpirsky:master from unknown repository

ghost commented Feb 14, 2017

Wrote a script that edited all JSON files so they fix issue #62. @umpirsky please review.


          JSON files fixed issue #62

ebb6c24

Owner

umpirsky commented Feb 15, 2017

@kosanovic This repository uses https://github.com/umpirsky/list-generator to generate the list. So, the right thing to do would be to update https://github.com/umpirsky/list-generator/blob/master/src/Umpirsky/ListGenerator/Exporter/Format/Json.php to export according to new format and use that instead.
Reason: If we do it like you proposed, changes will be lost on next build.
So, here is how it goes:

We update https://github.com/umpirsky/list-generator/blob/master/src/Umpirsky/ListGenerator/Exporter/Format/Json.php.
Release new version of https://github.com/umpirsky/list-generator
We update this repo to use new version (composer update ...)
Then we build.

Thanks.

ghost closed this

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet