Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 가게 상세 페이지 디자인 #80

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

l-lyun
Copy link
Contributor

@l-lyun l-lyun commented Nov 14, 2024

#️⃣연관된 이슈

resolves: #79

📝작업 내용

iOS Android
iOS Image Android Image

스크린샷 (선택)

💬리뷰 요구사항(선택)

승민이형 MarketDetail 변수명 깔끔하게 하셨는데 디자인 제가 잘못해서 그런거 같습니다 망쳐놨네요..
차후 잘 고쳐보겠습니다...

@l-lyun l-lyun assigned l-lyun, 99mini and itslitulinchpin2 and unassigned l-lyun Nov 14, 2024
Copy link
Contributor

@itslitulinchpin2 itslitulinchpin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳 변수명 벡앤드에 맞춘거죠? ios에서는 되는데 안드로이드에서 자동으로 스크롤바에 첫번째 태그로 디폴트 설정이 안되는것같은데 (사진에서 볶음으로) ..사소하니 제가 고칠게요~ 세로 픽셀만 고치면 될듯

Copy link
Contributor

@99mini 99mini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@99mini
Copy link
Contributor

99mini commented Nov 15, 2024

assign에는 자기자신 reviewer에 우리를 할당해주십시오

@l-lyun l-lyun merged commit ad45059 into main Nov 15, 2024
1 check passed
@99mini 99mini assigned l-lyun and unassigned 99mini and itslitulinchpin2 Nov 15, 2024
@99mini 99mini added the view label Nov 15, 2024
@l-lyun l-lyun deleted the feature/market-detail-page-design branch November 16, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(client/MarketDetail): 가게 상세 화면 디자인 작업
3 participants