Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 가게 상세 페이지 design 수정 #74

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

itslitulinchpin2
Copy link
Contributor

📝작업 내용

  • 가게 상세 페이지 디자인 수정합니다.
  • 장바구니 네비게이션 추가, 세부 페이지 정보도 피그마에 맞게 수정

스크린샷 (선택)

image

💬리뷰 요구사항(선택)

  • 아직 디자인 확정은 아닌데 그냥 앱 전체 UI 통일성이랑 장바구니 네비게이션 위해서 한번 머지되는게 좋을것 같네요
  • 아직 디자이너님과 논의할 사항이 다수라.. 우선 자의적으로 필요한 부분 수정했습니다.

@itslitulinchpin2 itslitulinchpin2 self-assigned this Nov 6, 2024
Copy link
Contributor

@99mini 99mini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~!

테마 적용가능한 부분은 테마 적용해서 관리하면 좋겠습니다

@@ -77,7 +77,7 @@ const MenuCounterButtonWrapper = styled.TouchableOpacity`
justify-content: center;
align-items: center;
width: 32px;
background-color: lightblue;
background-color: #70c802;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: #70c802;
background-color: ${props => props.theme.colors.primary}

theme를 적용할 수 있으면 적용해주세요! #70c802 hex code와 동일한 색깔입니다.

ref] feat: 테마 적용

Comment on lines 62 to 63
background-color: ${({selected}) => (selected ? '#70C802' : 'white')};
border: ${({selected}) => (selected ? '' : '1px solid #70C802')};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 테마 적용될 것 같네요

@itslitulinchpin2 itslitulinchpin2 merged commit de1e0b8 into main Nov 12, 2024
1 check passed
@itslitulinchpin2 itslitulinchpin2 deleted the fix/feed-page-design branch November 15, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants