-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler-webpack): requireHook add tapable #12358
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
漫步解读这次更新的重点在于对整体变化的高层摘要,而非特定文件,涉及对 变更
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Size Change: -1.14 kB (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/bundler-webpack/src/requireHook.ts (1 hunks)
- packages/preset-vue/src/index.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/preset-vue/src/index.ts
Additional comments not posted (1)
packages/bundler-webpack/src/requireHook.ts (1)
19-19
: 添加 'tapable' 的映射看起来是正确的,可以避免代码冗余并提高维护性。Verification successful
添加 'tapable' 的映射似乎没有与代码库中的其他依赖项发生冲突。以下是对每个文件中 'tapable' 引用的分析:
requireHook.ts
:包含新的映射。service.ts
和detectDeadCodePlugin.ts
:这两个文件使用的是编译后的 'tapable' 版本,与requireHook.ts
中的新映射一致。types.d.ts
:在类型定义中引用 'tapable',这应该不会直接与其他文件中的功能性使用发生冲突。因此,可以确认新的映射没有不良影响。
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new mapping for 'tapable' does not interfere with other dependencies. # Test: Search for any other mappings or uses of 'tapable' that might conflict with the new mapping. rg --type ts $'tapable'Length of output: 409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/bundler-webpack/src/requireHook.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/bundler-webpack/src/requireHook.ts
实际上这个地方是补不完的,这也导致了 #10583 与之关联的插件无法使用的问题。 除了现在可以修修补补做亡羊补牢,我在想要不要和 nextjs 一样加一个 比如 MF v2 中使用了大量的 webpack 导入,即使用如上 issue 中 workaround 的方法也是补不完的,所以还是得能跳过才行。 |
补齐 tapable 的映射 避免在多个地方重复弄
比如 dumi 的 https://github.com/umijs/dumi/blob/master/suites/preset-vue/src/requireHook.ts
Summary by CodeRabbit
requireHook.ts
的hookPropertyMap
中添加了'tapable'
到'@umijs/bundler-utils/compiled/tapable'
的映射处理。packages/preset-vue/src/index.ts
中移除了import './requireHook'
的导入语句。