-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ssr): correct logic for get dist path #11729
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +28 B (0%) Total Size: 10.2 MB
ℹ️ View Unchanged
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11729 +/- ##
==========================================
- Coverage 28.94% 28.93% -0.01%
==========================================
Files 485 485
Lines 14775 14776 +1
Branches 3501 3501
==========================================
Hits 4276 4276
- Misses 9739 9740 +1
Partials 760 760
☔ View full report in Codecov by Sentry. |
return join(api.paths.cwd, 'server', manifest.assets['umi.js']) | ||
// basename use to strip public path | ||
// ex. /foo/umi.xxx.js -> umi.xxx.js | ||
return join(api.paths.cwd, 'server', basename(manifest.assets['umi.js'])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该还有一个优化,就是把 absServerBuildPath
的返回值的 require.cache
删了,因为基本上调用 absServerBuildPath
的地方后续都手动删除了这个 cache ,多此一举。
修复 server 产物路径添加 hash 后(关联 PR:#11698 )引入的两个问题:
publicPath
时 server 产物路径获取错误的问题