Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using tsx loader to parse jsx files #11668

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Sep 20, 2023

fix #11646 (reply in thread)

当 jsx 文件中使用了装饰器,我们应该还使用 tsx loader 去解析他,因为 esbuild transform 不支持在 js 里用装饰器(最新版除外,因为从 v0.18.5 开始已经支持了 ecma 新版 deco )

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 7:49pm

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (422da05) 28.99% compared to head (e6bf273) 28.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11668   +/-   ##
=======================================
  Coverage   28.99%   28.99%           
=======================================
  Files         485      485           
  Lines       14729    14728    -1     
  Branches     3486     3486           
=======================================
  Hits         4271     4271           
+ Misses       9701     9700    -1     
  Partials      757      757           
Files Changed Coverage Δ
packages/bundler-utils/src/index.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sorrycc sorrycc merged commit dad6dc1 into umijs:master Sep 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants