-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): custom loading component for qiankun #11498
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +183 B (0%) Total Size: 10.1 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11498 +/- ##
==========================================
- Coverage 29.05% 29.04% -0.02%
==========================================
Files 484 484
Lines 14688 14696 +8
Branches 3466 3469 +3
==========================================
Hits 4268 4268
- Misses 9666 9674 +8
Partials 754 754
☔ View full report in Codecov by Sentry. |
这个地方有一个问题是,现在把 |
但是在我们现在的架构下,用户没有办法感知并去修改这个东西。站点编排的时候没有办法搞个 function,即使后面支持了,每个子应用都写,也会有些麻烦? 现在这种模式,可以交给主应用统一掉 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
类型也要补充一下
export type MasterOptions = { |
需求背景详细描述一下吧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
const loader = api.config.qiankun?.master?.loader; | ||
assert( | ||
!loader || loader.startsWith?.('@/'), | ||
'[@umijs/plugin-qiankun]: loader only support root path, eg: @/loading', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个版本这个提示文案得改一下,root path
=> src path
|
||
`CustomLoader` 跟上述实现一致,接收一个 `loading` 为 `boolean` 类型的参数。 | ||
|
||
注意:`master.loader` 不默认开启加载动画,开启动画需要将 `autoSetLoading` 设置为 `true`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不对吧?配置了 loader 就能自动把状态传进去了
``` | ||
其中,`loader` 为文件路径,统一约定放在 [src 目录](../guides/directory-structure.md#src-目录) 下,在 umi 中 `@` 即代表 `src` 目录。 | ||
|
||
`CustomLoader` 跟上述实现一致,接收一个 `loading` 为 `boolean` 类型的参数。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个描述不对,跟上面的 CustomLoader 不一样,这里是 (loading) => <CustomLoader loading={loading} />
需求背景
autoSetLoading
只能加载默认的动画,灵活性较差,用户希望可以通过统一的方式扩展子应用的加载动画。用户期望可以像
initialState.loading
配置的方式一样:实现与使用姿势
扩展 qiankun master 配置,支持传递文件路径,使用姿势如下: