fix: Fix the judgment logic of isHomePage in QIANKUN #11265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11265 +/- ##
==========================================
+ Coverage 29.01% 29.15% +0.13%
==========================================
Files 484 483 -1
Lines 14708 14607 -101
Branches 3474 3447 -27
==========================================
- Hits 4268 4258 -10
+ Misses 9683 9601 -82
+ Partials 757 748 -9 ☔ View full report in Codecov by Sentry. |
fz6m
reviewed
Jun 12, 2023
| @@ -31,10 +33,12 @@ export default (props: any) => { | |||
| }, []); | |||
|
|
|||
| const { title, description } = props.themeConfig; | |||
|
|
|||
| const location = useLocation?.(); | |||
There was a problem hiding this comment.
会的。没有加的话测试用例报错。如果使用了 mpa 模式也会出问题。
There was a problem hiding this comment.
后面 umi 文档应该要迁移到 dumi ，这个地方感觉不太优雅。
There was a problem hiding this comment.
之前用 try-catch 搞了一个版本，感觉太丑了，就换成可选链了。
要不先合了？如果微前端部署的话，home page 判断错误，永远跳不了主页了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isHomePage 的判断逻辑漏掉了以微前端方式部署 doc 时情况。