-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remaining incentive module unit tests #2061
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
- Coverage 75.38% 74.82% -0.57%
==========================================
Files 100 126 +26
Lines 8025 9632 +1607
==========================================
+ Hits 6050 7207 +1157
- Misses 1589 1948 +359
- Partials 386 477 +91
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start of the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have more tests which can interface the flow... eg: bond --> unbond partially --> check if rewards were paid --> more people bond --> wait few blocks --> see if rewards are distributed correctly. I can create few tasks with specific flows we should test.
NOTE: Would be good to follow the KeeperBuilder
pattern (but this is not blocking the PR).
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
closes: #2005
progress: #1990
Note: What remains in #1990 is the leverage-side tests (basically
hooks_test.go
but run from the leverage module during its integration tests) and some edge cases.