Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix library lookup with prefixed orcabusId #626

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix library lookup with prefixed orcabusId #626

merged 1 commit into from
Oct 30, 2024
+34 −6

Conversation

reisingerf
Copy link
Member

As noted in the test:

  • for library lookup and library record generation a "sanitised" orcabusId is used (e.g. ULID only, prefix stripped off)
  • for the event relay the original values from the input event are forwarded as is to the output event

(not a permanent nor elegant solution)

@reisingerf reisingerf self-assigned this Oct 30, 2024
victorskl
victorskl approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Flo!

@victorskl victorskl added the fix label Oct 30, 2024
@victorskl
Copy link
Member

Flo, merging this to cover CI build lead time...

@victorskl victorskl merged commit 6ad00dd into main Oct 30, 2024
6 checks passed
@victorskl victorskl deleted the fix/wfm-lib-dynamic-creation branch October 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@alexiswl alexiswl alexiswl approved these changes

Assignees

@reisingerf reisingerf

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reisingerf @victorskl @alexiswl