Feat: Add Authoriser Based on User Pool Group #617
Conversation
| @@ -153,12 +153,14 @@ export class Filemanager extends Stack { | |||
| new HttpRoute(this, 'PatchHttpRoute', { | |||
| httpApi: httpApi, | |||
| integration: apiIntegration, | |||
| authorizer: apiGateway.cognitoAdminGroupAuthorizer, | |||
There was a problem hiding this comment.
I think the FM might be a use case where only the admin user (including orcabus_token) could do non-read methods (e.g. POST, PATCH). @mmalenic
There was a problem hiding this comment.
@victorskl Just an important note on each stage we must put the orcabus_token service on the admin Cognito group and refresh the service JWT rotator to get the latest token claim.
There was a problem hiding this comment.
Got it, will do. Thanks, Will.
williamputraintan
requested review from
reisingerf,
mmalenic,
victorskl and
raylrui
and removed request for
reisingerf and
mmalenic
|
@williamputraintan Ok to merge? |
Yes, but we would probably need cognito in stg and prod to sync up. Happy if we want to leave this out from O3 ? |
|
Yup, will sync up cognito accordingly, Will. No worries. |
|
Ok, will merge after the testing of resolved conflict is finished. |
Depends on umccr/infrastructure#487