Hotfix/add disposition params for s3 presign url api #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2024
|
Reviewing... |
victorskl
approved these changes
Jul 11, 2024
|
Merge when you ready, Ray. |
|
merged, think of publishing..... |
victorskl
deleted the
hotfix/add-disposition-params-for-s3-presign-url-api
branch
|
I will publish it to PyPI. |
|
I will update the portal-apis PR deps when it is ready |
|
0.4.0rc4 is in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
content_dispositionparam in thelibumccr.aws.libs3.presign_s3_filefunction.inlinewill not change the default behaviour as before.Refer: about
ResponseContentDispositionParams in the boto3 s3 client, boto/boto3#356 (comment)boto/boto3#610 (comment)
Link:
apis of PR, umccr/data-portal-apis#705
ui issues, umccr/data-portal-client#342