-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V16 QA Added acceptance tests for granular document permission #19546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nhudinh0309
wants to merge
8
commits into
main
Choose a base branch
from
v16/QA/granular-document-permission-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+344
−1
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
22b647d
Added tests for granular document permission
nhudinh0309 45e9b79
Merge branch 'main' into v16/QA/granular-document-permission-tests
nhudinh0309 4d521f2
Updated tests for Webhook
nhudinh0309 3bab9c3
Bumped version
nhudinh0309 86eac63
Make all tests for granular permission run in the pipeline
nhudinh0309 aa19334
Merge branch 'main' into v16/QA/granular-document-permission-tests
nhudinh0309 aaa5515
Added issue link for the failing tests
nhudinh0309 9a2b50b
Merge branch 'main' into v16/QA/granular-document-permission-tests
nhudinh0309 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
343 changes: 343 additions & 0 deletions
343
...Test/tests/DefaultConfig/Users/Permissions/UserGroup/GranularPermissionsInContent.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,343 @@ | ||
import {ConstantHelper, NotificationConstantHelper, test} from "@umbraco/playwright-testhelpers"; | ||
import {expect} from "@playwright/test"; | ||
|
||
// Document Type | ||
const documentTypeName = 'DocumentType'; | ||
const childDocumentTypeName = 'ChildDocumentType'; | ||
let documentTypeId = null; | ||
let childDocumentTypeId = null; | ||
|
||
// Document | ||
const firstDocumentName = 'FirstDocumentName'; | ||
const secondDocumentName = 'SecondDocumentName'; | ||
const childDocumentName = 'ChildDocumentName'; | ||
let firstDocumentId = null; | ||
let secondDocumentId = null; | ||
|
||
// Data Type | ||
const dataTypeName = 'Textstring'; | ||
let dataTypeId = null; | ||
const documentText = 'This is test document text'; | ||
|
||
// Document Blueprint | ||
const testDocumentName = 'TestDocument'; | ||
const documentBlueprintName = 'TestBlueprintName'; | ||
|
||
// User | ||
const testUser = ConstantHelper.testUserCredentials; | ||
let testUserCookieAndToken = {cookie: "", accessToken: "", refreshToken: ""}; | ||
|
||
const userGroupName = 'TestUserGroup'; | ||
let userGroupId = null; | ||
|
||
test.beforeEach(async ({umbracoApi}) => { | ||
await umbracoApi.documentType.ensureNameNotExists(documentTypeName); | ||
await umbracoApi.documentType.ensureNameNotExists(childDocumentTypeName); | ||
await umbracoApi.documentBlueprint.ensureNameNotExists(documentBlueprintName); | ||
await umbracoApi.user.ensureNameNotExists(testUser.name); | ||
await umbracoApi.userGroup.ensureNameNotExists(userGroupName); | ||
const dataType = await umbracoApi.dataType.getByName(dataTypeName); | ||
dataTypeId = dataType.id; | ||
childDocumentTypeId = await umbracoApi.documentType.createDefaultDocumentType(childDocumentTypeName); | ||
documentTypeId = await umbracoApi.documentType.createDocumentTypeWithAllowedChildNodeAndDataType(documentTypeName, childDocumentTypeId, dataTypeName, dataTypeId); | ||
firstDocumentId = await umbracoApi.document.createDocumentWithTextContent(firstDocumentName, documentTypeId, documentText, dataTypeName); | ||
secondDocumentId = await umbracoApi.document.createDocumentWithTextContent(secondDocumentName, documentTypeId, documentText, dataTypeName); | ||
}); | ||
|
||
test.afterEach(async ({umbracoApi}) => { | ||
// Ensure we are logged in to admin | ||
await umbracoApi.loginToAdminUser(testUserCookieAndToken.cookie, testUserCookieAndToken.accessToken, testUserCookieAndToken.refreshToken); | ||
await umbracoApi.document.ensureNameNotExists(firstDocumentName); | ||
await umbracoApi.document.ensureNameNotExists(secondDocumentName); | ||
await umbracoApi.documentType.ensureNameNotExists(documentTypeName); | ||
await umbracoApi.documentType.ensureNameNotExists(childDocumentTypeName); | ||
await umbracoApi.documentBlueprint.ensureNameNotExists(documentBlueprintName); | ||
await umbracoApi.userGroup.ensureNameNotExists(userGroupName); | ||
}); | ||
|
||
test('can read a specific document with read permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithReadPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.userGroup.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.goToContentWithName(firstDocumentName); | ||
|
||
// Assert | ||
await umbracoUi.content.doesDocumentHaveName(firstDocumentName); | ||
await umbracoUi.content.goToContentWithName(secondDocumentName); | ||
await umbracoUi.content.isErrorNotificationVisible(); | ||
}); | ||
Check warning on line 73 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/Permissions/UserGroup/GranularPermissionsInContent.spec.ts
|
||
|
||
test('can create document blueprint for a specific document with create document blueprint permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithCreateDocumentBlueprintPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickCreateBlueprintActionMenuOption(); | ||
await umbracoUi.content.enterDocumentBlueprintName(documentBlueprintName); | ||
await umbracoUi.content.clickSaveDocumentBlueprintButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.documentBlueprintCreated); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can delete a specific content with delete permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithDeletePermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickTrashActionMenuOption(); | ||
await umbracoUi.content.clickConfirmTrashButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.movedToRecycleBin); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can create content from a specific content with create permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithCreatePermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
|
||
// Assert | ||
await umbracoUi.content.isPermissionInActionsMenuVisible('Create…'); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can publish a specific content with publish permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithPublishPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickPublishActionMenuOption(); | ||
await umbracoUi.content.clickConfirmToPublishButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.waitForContentToBePublished(); | ||
expect(await umbracoApi.document.isDocumentPublished(firstDocumentId)).toBeTruthy(); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
// Issue link: https://github.com/umbraco/Umbraco-CMS/issues/19339 | ||
test.skip('can set permissions for a specific content with set permissions permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithSetPermissionsPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
// await umbracoUi.content.clickSetPermissionsButton(); | ||
// | ||
// // Assert | ||
// await umbracoUi.content.doesDocumentPermissionsDialogExist(); | ||
// await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can unpublish a specific content with unpublish permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
await umbracoApi.document.publish(firstDocumentId); | ||
await umbracoApi.document.publish(secondDocumentId); | ||
expect(await umbracoApi.document.isDocumentPublished(firstDocumentId)).toBeTruthy(); | ||
expect(await umbracoApi.document.isDocumentPublished(secondDocumentId)).toBeTruthy(); | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithUnpublishPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickUnpublishActionMenuOption(); | ||
await umbracoUi.content.clickConfirmToUnpublishButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.unpublished); | ||
expect(await umbracoApi.document.isDocumentPublished(firstDocumentId)).toBeFalsy(); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
// Issue link: https://github.com/umbraco/Umbraco-CMS/issues/19286 | ||
test.skip('can update a specific content with update permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithUpdatePermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.goToContentWithName(firstDocumentName); | ||
await umbracoUi.content.enterContentName(testDocumentName); | ||
await umbracoUi.content.clickSaveButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.isSuccessStateVisibleForSaveButton(); | ||
expect(await umbracoApi.document.doesNameExist(testDocumentName)).toBeTruthy(); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can duplicate a specific content with duplicate permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithDuplicatePermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
// Duplicate to root | ||
await umbracoUi.content.clickDuplicateToActionMenuOption(); | ||
await umbracoUi.content.clickLabelWithName('Content'); | ||
await umbracoUi.content.clickDuplicateButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.duplicated); | ||
await umbracoUi.content.clickActionsMenuForContent(secondDocumentName); | ||
await umbracoUi.content.isPermissionInActionsMenuVisible('Duplicate to…', false); | ||
}); | ||
|
||
// Issue link: https://github.com/umbraco/Umbraco-CMS/issues/19547 | ||
test.skip('can move a specific content with move to permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This issue is fixed 😄 |
||
// Arrange | ||
const moveToDocumentName = 'MoveToDocument'; | ||
await umbracoApi.document.createDefaultDocumentWithParent(childDocumentName, childDocumentTypeId, firstDocumentId); | ||
await umbracoApi.document.createDocumentWithTextContent(moveToDocumentName, documentTypeId, documentText, dataTypeName); | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithMoveToPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickCaretButtonForContentName(firstDocumentName); | ||
await umbracoUi.content.clickActionsMenuForContent(childDocumentName); | ||
await umbracoUi.content.clickMoveToActionMenuOption(); | ||
await umbracoUi.content.moveToContentWithName([], moveToDocumentName); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.moved); | ||
await umbracoUi.content.clickActionsMenuForContent(secondDocumentName); | ||
await umbracoUi.content.isPermissionInActionsMenuVisible('Move to…', false); | ||
}); | ||
|
||
test('can sort children with sort children permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
await umbracoApi.document.createDefaultDocumentWithParent(childDocumentName, childDocumentTypeId, firstDocumentId); | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithSortChildrenPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
|
||
// Assert | ||
await umbracoUi.content.isPermissionInActionsMenuVisible('Sort children…'); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can set culture and hostnames for a specific content with culture and hostnames permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
const domainName = '/domain'; | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithCultureAndHostnamesPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickCultureAndHostnamesActionMenuOption(); | ||
await umbracoUi.content.clickAddNewDomainButton(); | ||
await umbracoUi.content.enterDomain(domainName); | ||
await umbracoUi.content.clickSaveModalButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.waitForDomainToBeCreated(); | ||
const document = await umbracoApi.document.getByName(firstDocumentName); | ||
const domains = await umbracoApi.document.getDomains(document.id); | ||
expect(domains.domains[0].domainName).toEqual(domainName); | ||
expect(domains.domains[0].isoCode).toEqual('en-US'); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); | ||
|
||
test('can set public access for a specific content with public access permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithPublicAccessPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
const testMemberGroup = 'TestMemberGroup'; | ||
await umbracoApi.memberGroup.ensureNameNotExists(testMemberGroup); | ||
await umbracoApi.memberGroup.create(testMemberGroup); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickPublicAccessActionMenuOption(); | ||
await umbracoUi.content.addGroupBasedPublicAccess(testMemberGroup, firstDocumentName); | ||
|
||
// Assert | ||
await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.publicAccessSettingCreated); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
|
||
// Clean | ||
await umbracoApi.memberGroup.ensureNameNotExists(testMemberGroup); | ||
}); | ||
|
||
test('can rollback a specific content with rollback permission enabled', async ({umbracoApi, umbracoUi}) => { | ||
// Arrange | ||
userGroupId = await umbracoApi.userGroup.createUserGroupWithRollbackPermissionForSpecificDocument(userGroupName, firstDocumentId); | ||
await umbracoApi.document.publish(firstDocumentId); | ||
const updatedTextStringText = 'This is an updated textString text'; | ||
const contentData = await umbracoApi.document.get(firstDocumentId); | ||
contentData.values[0].value = updatedTextStringText; | ||
await umbracoApi.document.update(firstDocumentId, contentData); | ||
await umbracoApi.document.publish(firstDocumentId); | ||
await umbracoApi.user.setUserPermissions(testUser.name, testUser.email, testUser.password, userGroupId); | ||
testUserCookieAndToken = await umbracoApi.user.loginToUser(testUser.name, testUser.email, testUser.password); | ||
await umbracoUi.goToBackOffice(); | ||
await umbracoUi.content.goToSection(ConstantHelper.sections.content, false); | ||
|
||
// Act | ||
await umbracoUi.content.clickActionsMenuForContent(firstDocumentName); | ||
await umbracoUi.content.clickRollbackActionMenuOption(); | ||
await umbracoUi.content.clickLatestRollBackItem(); | ||
await umbracoUi.content.clickRollbackContainerButton(); | ||
|
||
// Assert | ||
await umbracoUi.content.goToContentWithName(firstDocumentName); | ||
await umbracoUi.content.doesDocumentPropertyHaveValue(dataTypeName, documentText); | ||
await umbracoUi.content.isActionsMenuForNameVisible(secondDocumentName, false); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was closed