V13: Add rcl files to static files tree #17671
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.29 (9.24 -> 8.96)
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication StaticFilesTreeController.cs
- Constructor Over-Injection StaticFilesTreeController.cs: StaticFilesTreeController
✅ Improving Code Health:
- Complex Method StaticFilesTreeController.cs: GetTreeNodes
- Complex Conditional StaticFilesTreeController.cs: GetTreeNodes
Annotations
Check warning on line 38 in src/Umbraco.Web.BackOffice/Trees/StaticFilesTreeController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: StaticFilesTreeController,StaticFilesTreeController. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check notice on line 136 in src/Umbraco.Web.BackOffice/Trees/StaticFilesTreeController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ No longer an issue: Complex Method
GetTreeNodes is no longer above the threshold for cyclomatic complexity
Check notice on line 67 in src/Umbraco.Web.BackOffice/Trees/StaticFilesTreeController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ No longer an issue: Complex Conditional
GetTreeNodes no longer has a complex conditional
Check warning on line 38 in src/Umbraco.Web.BackOffice/Trees/StaticFilesTreeController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
StaticFilesTreeController has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.