-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve document schedule #17535
Open
Migaroez
wants to merge
21
commits into
v15/dev
Choose a base branch
from
v15/task/improve-document-schedule
base: v15/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve document schedule #17535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Cms.Api.Management/Factories/DocumentPresentationFactory.cs # src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs
bergmania
reviewed
Nov 25, 2024
src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyDocumentController.cs
Outdated
Show resolved
Hide resolved
Migaroez
changed the title
V15/task/improve document schedule
Improve document schedule
Nov 26, 2024
bergmania
reviewed
Nov 26, 2024
bergmania
reviewed
Nov 26, 2024
Co-authored-by: Bjarke Berg <[email protected]>
Co-authored-by: Bjarke Berg <[email protected]>
bergmania
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix conflicts but otherwise I think it looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Management API currently supports publishing OR scheduling of documents, but there is no way to cancel schedules or clear them.
This PR aims to rectify this shortcoming while still maintaining the API model/endpoint and the spirit of the endpoint.
Details
With this PR, it should be possible to
Notes
A few things came up while making the necessary changes, please keep these in mind when reviewing/testing this PR
""
and"*"
, where it makes sense (and there was no sign it would cause any issues) this has been aligned to "*" and placed in a constant for clarityTesting
You can look for inspiration in the added integration tests, but please try to think outside the box.