chore: move DrawToolbar and SettingsToolbar to bar.js module #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also: - change the "set center and zoom" to be a panel instead of a direct action (including the "defaultView" setting - refactor the "get started dialog" This is a first step to remove our dependency to the unmaintained Leaflet.Toolbar plugin.
davidbgk
approved these changes
Feb 6, 2025
Co-authored-by: Yohan Boniface <[email protected]>
Co-authored-by: Yohan Boniface <[email protected]>
Co-authored-by: Yohan Boniface <[email protected]>
Co-authored-by: Yohan Boniface <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also:
This is a first step to remove our dependency to the unmaintained Leaflet.Toolbar plugin.
The mockup on figma glues the edit toolbar to the edit panel, but I didn't not implement this as I don't know how to make it work in portrait/mobile view. This step is mainly a code refactor.