Campus logic update #18
Conversation
… in their Alma record. Corrected a comment typo.
| @@ -38,7 +38,7 @@ | |||
| *returns ExLibris API function | |||
| */ | |||
| public function __construct(){ | |||
| include_once 'vendor/tcdent/php-restclient/restclient.php'; | |||
| include_once 'php-restclient/restclient.php'; | |||
There was a problem hiding this comment.
This is sourced here: https://github.com/tcdent/php-restclient , and is maintained, so we probably should be using composer for dependency management (or a git submodule).
workflow.php
Outdated
| <p>Law School users, please see <a href="https://www.library.law.pitt.edu/research/interlibrary-loan-delivery">https://www.library.law.pitt.edu/research/interlibrary-loan-delivery</a> for interlibrary loan inforrmation.</p> | ||
| LAW_PATRON; | ||
| break; | ||
| case "unknownCampus": |
There was a problem hiding this comment.
The message for "unknownCampus" and "blankCampus" is nearly identical, and the action of the patron (askUs) and of the staff (lookup the record) is identical. This could potentially be simplified.
…vely. This eliminates the need to individually map query string parameters to form field names. Add other special borrower types for exclusion from external borrowing requests
…th remote borrowing privs to ULS Illiad. Will apply by default for any new campuses added to Alma
…o reduce number of API calls, refactor to continue to treat law campus patrons separately while using simplified logic overall
workflow.php
Outdated
| $campus = $userRecord->campus_code->value; | ||
| } | ||
| //Barco Law Library users do not participate in Illiad, so we'll handle them separately later | ||
| if ($user->getUserRecord($userId)->campus_code->value==='LAW' && $requestStatus !== 'specialBorrower') { |
There was a problem hiding this comment.
Why doesn't this also use $userRecord, and will it not throw warning if ->campus_code does not have a ->value property?
There was a problem hiding this comment.
Resolved by moving this inside the conditional that checks for the value property. No reason not to use $userRecord here. Switched. Thank you!
… use the cached user record instead of a separate API call
No description provided.